[FFmpeg-devel] [PATCH] avcodec/get_bits: consider bit_size of 0 an error

[Paul B Mahol]

On 10/28/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Oct 28, 2013 at 04:52:27PM +0000, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavcodec/get_bits.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> this patch breaks fate
>
> --- ./tests/ref/vsynth/vsynth1-amv  2013-10-27 10:50:19.684710120 +0100
> +++ tests/data/fate/vsynth1-amv 2013-10-28 20:15:15.559244425 +0100
> @@ -1,4 +1,2 @@
>  34c4d4033d31c7401d32fee9d6ce0de2 *tests/data/fate/vsynth1-amv.avi
>  1365496 tests/data/fate/vsynth1-amv.avi
> -e38681b9527b6d2531942f8a176a0265 *tests/data/fate/vsynth1-amv.out.rawvideo
> -stddev:   10.07 PSNR: 28.06 MAXDIFF:   98 bytes:  7603200/  7603200
> Test vsynth1-amv failed. Look at tests/data/fate/vsynth1-amv.err for
> details.

You need another patch that fixes crash for bit_size < 0, applied
before this one.

Yes I posted them in wrong order.

>
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Opposition brings concord. Out of discord comes the fairest harmony.
> -- Heraclitus
>