[FFmpeg-devel] [PATCHv3 2/7] avpacket: add pack/unpack functions for AVDictionary

[wm4]

On Tue, 29 Oct 2013 00:11:36 +0000 (UTC)
Ben Boeckel <mathstuf at gmail.com> wrote:

> On Mon, 28 Oct, 2013 at 18:56:08 GMT, wm4 wrote:
> > Should this mention the need for input padding? (I'm not so familiar
> > with the conventions in the API, and whether input padding is
> > explicitly documented or not.)
> 
> I don't think this is padded...maybe there's something implicit hanging
> around?

All side data is implicitly padded with FF_INPUT_BUFFER_PADDING_SIZE,
which is also why av_packet_unpack_dictionary() can run strlen() on the
side data without knowing whether the data itself is 0-terminated.

> > Maybe this should return AVERROR_INVALIDDATA?
> 
> That would be better.
> 
> > Rest looks good to me. Probably also needs an doc/APIchanges entry.
> 
> Will do. I should also update the micro version as well I suppose?

Perhaps. I think the committer/pusher usually does this?