[FFmpeg-devel] [PATCH] lavfi: port phase filter from libmpcodecs

[Stefano Sabatini]

On date Monday 2013-09-02 18:48:40 +0000, Paul B Mahol encoded:
> On 9/2/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Monday 2013-09-02 14:06:13 +0000, Paul B Mahol encoded:
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  Changelog                |   1 +
> >>  LICENSE                  |   1 +
> >>  configure                |   1 +
> >>  doc/filters.texi         |  61 +++++++++
> >>  libavfilter/Makefile     |   1 +
> >>  libavfilter/allfilters.c |   1 +
> >>  libavfilter/version.h    |   4 +-
> >>  libavfilter/vf_phase.c   | 313
> >> +++++++++++++++++++++++++++++++++++++++++++++++
> >>  8 files changed, 381 insertions(+), 2 deletions(-)
> >>  create mode 100644 libavfilter/vf_phase.c
> >>
> 
> Everything mentioned changed.
> 
> [...]
> 
> > [...]
> >
> > Should be fine assuming that it's bit identical with mp=phase.
> >
> > Looks fine otherwise, but please wait one day so I can have a more
> > indepth look at the algorithm.
> 
> Why you decided just now to make academic research on 'algorithm'
> in this filter? And why would it take one day to take a look at it?

It's more like I wanted not to miss the opportunity of spotting some
obvious issues (which were discovered when porting other filters).

After checking the code I have no more comments (but please split long
lines). Feel free to push if no one has more comments.
-- 
FFmpeg = Fiendish Friendly Mythic Portable Enhancing Gem