[FFmpeg-devel] [PATCH] TLS OPENSSL SSL_get_error

[Mirko Puliafito]

>
>
> please dont mix unrelated changes in the same patch
> (changing if/else to switch is unrelated)
>
> Feedbacks from other users were to change if/else to switch for a
stylistic improvement. I can switch back if necessary.



>
> > +    case SSL_ERROR_SYSCALL:
> > +        return AVERROR(errno);
>
> can errno be 0 here ?
>

No as per openssl doc

> also the code in tls_open() doesnt look like it handles EAGAIN that
> this seems to be intended to return
> the other callers look like they would busy loop
>
>
tls_open correclty closes as the connection it isn't created. tls_read and
tls_write tries again till the resource is available or close is called. To
me seems correct, what do you think?



> also make sure your code is tested before posting
>
>
It is.