[FFmpeg-devel] [PATCH] lavf/subtitles: Make comment less arrogant

Alexander Strasser eclipse7 at gmx.net
Tue Sep 10 23:05:56 CEST 2013


On 2013-09-09 17:18 -0700, Timothy Gu wrote:
> On Sep 9, 2013 4:08 PM, "Alexander Strasser" <eclipse7 at gmx.net> wrote:
> >
> >
> > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> > ---
> >
> >   I beg people to refrain from comments like this. I believe it does
> > more harm than it helps.
> >
> >  libavformat/subtitles.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> LGTM

  Thanks for reading; will push soon.

> [...]

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130910/c6a6bfcf/attachment.asc>


More information about the ffmpeg-devel mailing list