[FFmpeg-devel] [PATCH] Add --avlog-limit configure option.

[Don Moir]

----- Original Message ----- 
From: "Don Moir" <donmoir at comcast.net>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Wednesday, September 11, 2013 10:39 PM
Subject: Re: [FFmpeg-devel] [PATCH] Add --avlog-limit configure option.


----- Original Message ----- 
From: "Reimar Döffinger" <Reimar.Doeffinger at gmx.de>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Wednesday, September 11, 2013 4:14 PM
Subject: Re: [FFmpeg-devel] [PATCH] Add --avlog-limit configure option.


On Wed, Sep 11, 2013 at 07:06:32PM +0100, Derek Buitenhuis wrote:
> On 9/10/2013 6:24 PM, Reimar Döffinger wrote:
>> > This allows compiling out messages below a certain level.
>> > Note that it might cause some strange behaviour with the
>> > help printout of the command-line tools.

>> Some of the NULL_IF_CONFIG_SMALL stuff gains us less.
>> And for something like e.g. a Windows GUI program linking against
>> libav* these messages are likely close to completely useless.
>> If people think it's too ugly for the value I don't have much of
>> an issue dropping it though, I just wanted to see what is necessary
>> for it.
>> Longer term, I was wondering about using this scheme as a replacement
>> for av_dlog.

Tried a few limit values like:

--avlog-limit=fatal and --avlog-limit=warning

These worked fine for me. Since I don't deal with the command line tools, I did not test that, but looking at the callbacks in my 
own app it is doing the exact right thing.

It could be that using something like: --avlog-limit=AV_LOG_FATAL might be more natural instead of introducing new values.

Outside of that, I don't like to say LGTM because that is not enough most of the time, but LGTM and tested at least from my apps 
point of view.

I hope you will decide to push it at some point. Gives a nice reduction in size and removes many unneeded function calls.