[FFmpeg-devel] [PATCH] avfilter: port pullup filter from libmpcodecs

[Paul B Mahol]

On 9/18/13, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
>
>> On the serious side, if there are issues remaining,
>> visit trac.ffmpeg.org
>
> Sure, but don't you agree that these are issues that should
> either be addressed before commit or at least agreed that
> they (for whatever reason) cannot be fixed atm?

You and all the rest of MPlayer tead had almost 10 years to fix
those issue in mp=pullup itself, and not just in this filter
but in any other filter and any other part of MPlayer codebase.

If I were in postion to fix all issues that I found I certainly
would fix them all.

> I agree both that this is an important feature and that it
> is very helpful that you have ported it but now we have a
> memleak, invalid memory access (did anyone already test on
> Windows?) and I don't think a user can guess how to
> actually use the filter (this is not much different from
> fieldmatch but this is "no excuse" iiuc) because you did
> not want to spend the additional hour on it.

You did not spent single minute on it and yet find that your
responsibility is to judge.

> (I have no idea why one frame is still around after eof
> but I would expect you to know soon.)
>
> And it not 100% clear why the valgrind output on trac
> would help but does not help on the mailing list.

Because at that time filter was not committed.

>
> Sorry, Carl Eugen

No, you are really not.