[FFmpeg-devel] [PATCH]Remove incorrect assert from amr demuxer

Michael Niedermayer michaelni at gmx.at
Fri Sep 27 15:20:25 CEST 2013


On Fri, Sep 27, 2013 at 08:53:54AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #3001, libavformat supports forcing the codec, so 
> asserting a specific codec in a demuxer is wrong, the assert is unneeded 
> because the condition is tested in the following line.
> 
> Please comment, Carl Eugen

>  amr.c |    2 --
>  1 file changed, 2 deletions(-)
> 458bfd05a1fccd5c94d91a978e4759fb277bcd06  patchamr.diff
> diff --git a/libavformat/amr.c b/libavformat/amr.c
> index 7201ac3..db9bb4e 100644
> --- a/libavformat/amr.c
> +++ b/libavformat/amr.c
> @@ -132,8 +132,6 @@ static int amr_read_packet(AVFormatContext *s, AVPacket *pkt)
>          };
>  
>          size = packed_size[mode];
> -    } else {
> -        av_assert0(0);
>      }

ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130927/5f7ea6f2/attachment.asc>


More information about the ffmpeg-devel mailing list