[FFmpeg-devel] [PATCH]Support broken prores in mkv

[wm4]

On Tue, 1 Apr 2014 09:19:36 +0200
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 4390b6b..2282af6 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -1760,6 +1760,9 @@ static int matroska_read_header(AVFormatContext *s)
>              fourcc              = AV_RL32(track->codec_priv.data + 16);
>              codec_id            = ff_codec_get_id(ff_codec_bmp_tags,
>                                                    fourcc);
> +            if (!codec_id)
> +                codec_id        = ff_codec_get_id(ff_codec_movvideo_tags,
> +                                                  fourcc);
>              extradata_offset    = 40;
>          } else if (!strcmp(track->codec_id, "A_MS/ACM") &&
>                     track->codec_priv.size >= 14         &&

Are you saying someone put MOV tags into AVI headers? Why should we
support that? And why does your second patch add prores related tags to
the RIFF table (i.e. what's used for AVI headers) anyway?

In case the patches are two proposed different solutions, yeah, pick
the riff one.