[FFmpeg-devel] To be or not to be working with libav (was: [PATCHv3] On2 VP7 decoder)

[Reimar Döffinger]

On 01.04.2014, at 17:11, wm4 <nfxjfg at googlemail.com> wrote:

> On Tue, 1 Apr 2014 16:44:20 +0200
> Vittorio Giovara <vittorio.giovara at gmail.com> wrote:
> 
>>> Keep in mind that not everyone targets his applications to run on Linux
>>> distros. So they will just pick one project and stick with it. And if
>>> that is FFmpeg (which generally has slightly more features and slightly
>>> fewer bugs),
>> 
>> Can we go past this FUD? There are bugs and features in both projects,
>> one could even state that a review-less project like ffmpeg could
>> introduce more bugs, but it's really not worth discussing it.
> 
> Complaining about FUD, and calling FFmpeg a "review-less project" just
> a sentence later...

I can only explain this by some people believing reviews == review process.
I still review (to varying degrees) basically all commits to libavcodec, libavformat and libavutil.
But I do so on the -cvslog list when I'm short on time, so I avoid spending my time on things someone didn't consider good enough anyway.
Yes, reviews catch a lot of bugs, but what is important is that they are done, how/how thorough they are done etc.
Having a process around it has some cost, and I can only see a significant benefit if without it no reviews are actually done (though even then I seriously doubt the benefit of forced reviews, and if you are going to force people, forcing them to write tests might be a better way to spend their time and goodwill, IMHO).