[FFmpeg-devel] [PATCH 2/3] configure: check and use -Werror=empty-body

[James Darnley]

On 2014-04-04 00:57, Michael Niedermayer wrote:
> On Fri, Apr 04, 2014 at 12:53:55AM +0200, James Darnley wrote:
>> On 2014-04-04 00:45, James Darnley wrote:
>>> Would have caught the trailing semi-colon in lavu/log.c that broke detection of
>>> 256 colour capable terminals.
>>> ---
>>>  configure |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 46452ee..cb76890 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4776,6 +4776,7 @@ check_cflags -Wundef
>>>  check_cflags -Wmissing-prototypes
>>>  check_cflags -Wno-pointer-to-int-cast
>>>  check_cflags -Wstrict-prototypes
>>> +check_cflags -Werror=empty-body
>>>  enabled extra_warnings && check_cflags -Winline
>>>  
>>>  check_disable_warning(){
>>>
>>
>> Is it ever not an error?
> 
> it could be if the body disappears due to a macro

Oh yes.  I have seen some macros conditionally defined as nothing in a
couple of places.

I'll change this and send another patch if you don't beat me to it.

I should also thank the one who told us the correct option.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 683 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140404/8197b1dd/attachment.asc>