[FFmpeg-devel] [PATCH 4/4] avfilter.h, buffer.c: use const src pointer in avfilter_copy_buffer_ref_props

[Roman Fietze]

Hello Michael,

On Thu, 03.04.2014 14:21:23 Michael Niedermayer wrote:

> applied

Thanks to apply the 3 patches out of the 4.

Is there a reason why you did not apply 3 of 4 from unimatrix 0
itself? ;)

If yes, can I do something to improve this patch?

The patch would avoid another warning in ffmpeg.c:do_streamcopy()
calling av_copy_packet_side_data() using a const AVPacket *pkt around
line 1652 (as of the current master).

And this patch does not have such ugly side effects like many other
const declarations, e.g. like AVCodec::encode2 having some const
pointer where most callbacks cannot offer constness.


Roman

-- 
Roman Fietze              Telemotive AG Buero Muehlhausen
Breitwiesen                             73347 Muehlhausen
Tel.: +49 7335 18493-45          http://www.telemotive.de