[FFmpeg-devel] [PATCH]Write tiff aspect ratio by default instead of dpi

[Michael Niedermayer]

On Fri, Apr 04, 2014 at 11:08:51PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > -    uint32_t res[2] = { s->dpi, 1 };    
> > > // image resolution (72/1)
> > > +    uint32_t resx[2] = { s->dpi ? s->dpi : 
> > > avctx->sample_aspect_ratio.den, 1 };
> > > +    uint32_t resy[2] = { s->dpi ? s->dpi : 
> > > avctx->sample_aspect_ratio.num, 1 };
> > 
> > i think this is wrong
> > shouldnt the dpi be adjusted when the aspect differs from 1:1
> 
> But isn't this unrelated to this patch?

well, there is dpi and there is the aspect
before the patch the dpi is stored with a square aspect
after the patch either the dpi is stored with a square aspect
or the aspect is stored without dpi

I dont think storing both is unrelated
unless thats something uncommon / not well supported


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140405/90e332c2/attachment.asc>