[FFmpeg-devel] [PATCH] [RFC] avcodec: export MB information in frame side data

[Clément Bœsch]

On Tue, Jul 22, 2014 at 01:51:46AM +0200, Michael Niedermayer wrote:
[...]
> > +typedef struct AVMBInfo_MB {
> 
>     > +    int8_t source; /* -1/+1 XXX: set exact relative ref frame instead of "direction" */
> 
> i suspect this is too small for long term references

Would signed 16-bit enough?

> 
> 
> > +    uint32_t type; /* how much codec specific can this be? */
> > +    uint8_t w, h;
> > +    uint16_t src_x, src_y;
> > +    uint16_t dst_x, dst_y;
> > +} AVMBInfo_MB;
> 
> as side data this is not optimal as it depends on native endianness
> making exchange of side data over the network or serialization
> into file storage more difficult

Any better suggestion that side-data?

> 
> also QP, intra prediction mode, ... is missing 
> 

Shouldn't we have QP in a separate side-data type?

Intrapred information isn't coded in the type (which is present in
AVMBInfo_MB)?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140805/2a63720d/attachment.asc>