[FFmpeg-devel] [PATCH] write reel_name metadata to tmcd atom

[Michael Niedermayer]

On Fri, Aug 08, 2014 at 10:37:06AM -0700, Mark Reid wrote:
> ---
>  libavformat/movenc.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 86dbe7f..fe4413c 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -1340,6 +1340,16 @@ static int mov_write_rtp_tag(AVIOContext *pb, MOVTrack *track)
>      return update_size(pb, pos);
>  }
>  
> +static int mov_write_source_reference_tag(AVIOContext *pb, MOVTrack *track, const char *reel_name){
> +    int64_t pos = avio_tell(pb);
> +    avio_wb32(pb, 0);                              /* size */
> +    ffio_wfourcc(pb, "name");                      /* Data format */

> +    avio_wb16(pb, strlen(reel_name));              /* string size */

forgot but strictly speaking this requires a check on the strlen
fitting in 16bit

can you send a patch added a check with appropriate action ?

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140809/ebde64b3/attachment.asc>