[FFmpeg-devel] [PATCH 3/4] dpx: abort if encrypted

[Reimar Döffinger]

On Wed, Aug 13, 2014 at 06:51:00PM +0200, Christophe Gisquet wrote:
> Hi,
> 
> 2014-08-13 18:46 GMT+02:00 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> > More specifically: how certain is it this value is always correct?
> > Failing to play an unencrypted file just because of a wrong flag (or even a single-bit corruption!) seems worse to me than trying to play an encrypted file.
> > I.e. shouldn't this rather just be a warning than hard failure?
> 
> True. So, should I also add a warning message, or remove the missing
> feature warning? They are not entirely duplicate.

I'd be more than happy to let you decide.
Personally I'd probably go with the missing feature and a warning
message on top instead of the return.