[FFmpeg-devel] [PATCH] isom: add ni24 to pcm_s24le

[Clément Bœsch]

On Mon, Aug 18, 2014 at 04:42:15PM -0400, compn wrote:
> patch requested by ubitux.
> 
> found in code dump from kierank:
> 
> +    { CODEC_ID_PCM_S24LE,       MKTAG('n', 'i', '2', '4') }, /* BBC
>   typo fix for using ni24 instead of in24 (#3051) */ //GARYH added
> 
> (sorry for inline)
> 

Why do you remove the comment? Please mention more exactly where this
comes from ("dump from kierank" gives no clue about authorship).

I'd suggest you mention all of this in the commit message (that is why I
wanted you to send a proper patch here; it's not about the diff itself).

> -compn
> 
> 
> diff --git a/libavformat/isom.c b/libavformat/isom.c
> index d768c32..613d5ec 100644
> --- a/libavformat/isom.c
> +++ b/libavformat/isom.c
> @@ -292,6 +292,7 @@ const AVCodecTag ff_codec_movaudio_tags[] = {
>      { AV_CODEC_ID_PCM_S16LE,       MKTAG('l', 'p', 'c', 'm') },
>      { AV_CODEC_ID_PCM_S24BE,       MKTAG('i', 'n', '2', '4') },
>      { AV_CODEC_ID_PCM_S24LE,       MKTAG('i', 'n', '2', '4') },
> +    { AV_CODEC_ID_PCM_S24LE,       MKTAG('n', 'i', '2', '4') },
>      { AV_CODEC_ID_PCM_S32BE,       MKTAG('i', 'n', '3', '2') },
>      { AV_CODEC_ID_PCM_S32LE,       MKTAG('i', 'n', '3', '2') },
>      { AV_CODEC_ID_PCM_S8,          MKTAG('s', 'o', 'w', 't') },
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140818/d2baca15/attachment.asc>