[FFmpeg-devel] [RFC] [PATCH] huffyuvenc, multithread and context=1

[Michael Niedermayer]

On Fri, Jun 13, 2014 at 12:56:30AM +0200, Christophe Gisquet wrote:
> Hi,
> 
> 2014-06-12 0:18 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> > i think adding a codec private option like
> > -non_deterministic 1
> > is safer than using the flags in terms of compatibility
> > it also would produce an error if the option is used with a encoder
> > which doesnt support it
> 
> I'm unsatisfied of the result I got (cf. patch). My knowledge of the
> various APIs is too limited for that, and the main issue it seems is
> that I need to set threading from huffyuvenc, but I can only hack my
> way through frame_thread_encoder.c
> 
> -- 
> Christophe

>  frame_thread_encoder.c |   10 +++++++++-
>  huffyuv.h              |    1 +
>  huffyuvenc.c           |   24 ++++++++++++++++++++++++
>  3 files changed, 34 insertions(+), 1 deletion(-)
> 694eebdb7c235fc7667d9c395cc1b63005f874bf  0002-huffyuvenc-add-a-non-deterministic-option.patch
> From dc4ce59bc081d048487c02983d5f5ee005076348 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Fri, 13 Jun 2014 00:21:44 +0200
> Subject: [PATCH 2/2] huffyuvenc: add a non-deterministic option
> 
> Not actually used in huffyuvenc, but rather in setting the frame
> threading.
> 
> Example for some files:
> context=0:       851974   27226   1137281
> context=1,ND=0:  471819   22604    972351
> context=1,ND=1:  472875   22673    972582
> ---
>  libavcodec/frame_thread_encoder.c | 10 +++++++++-
>  libavcodec/huffyuv.h              |  1 +
>  libavcodec/huffyuvenc.c           | 24 ++++++++++++++++++++++++
>  3 files changed, 34 insertions(+), 1 deletion(-)

added AVClass *class as you suggested

patch applied

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140819/1bbc14cf/attachment.asc>