[FFmpeg-devel] Incorrect AVSampleFormat for sample_fmts_s16p (libavcodec/adpcm.c)

[Michael Niedermayer]

On Tue, Aug 19, 2014 at 11:54:26AM -0700, Jonathan Morley wrote:
>  As of git: ea97859c8c218b83ab747a7eabcb88ca446f6751 line 1533 in
> libavcodec/adpcm.c contains:
> 
> static const enum AVSampleFormat sample_fmts_s16p[] = { AV_SAMPLE_FMT_S16,
> 
> I believe it should contain:
> 
> static const enum AVSampleFormat sample_fmts_s16p[] = { AV_SAMPLE_FMT_S16P,
> 
> Note the trailing "P" for the planar format. Patch attached below.

>  adpcm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 4e5488b2a28bd1201f723a22b657a3725543a7e4  adpcm_sample_fmts_s16p.patch
> From fc938285497400c2384aaaf9e7b973a676815910 Mon Sep 17 00:00:00 2001
> From: Jon Morley <jon at tweaksoftware.com>
> Date: Tue, 19 Aug 2014 11:17:49 -0700
> Subject: [PATCH] Incorrect AVSampleFormat for sample_fmts_s16p
>  (libavcodec/adpcm.c) The AVSampleFormat list of sample_fmts_s16p is missing
>  the trailing "P" for planar formats. AV_SAMPLE_FMT_S16 vs AV_SAMPLE_FMT_S16P
> 
> ---
>  libavcodec/adpcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140819/42e134b8/attachment.asc>