[FFmpeg-devel] [PATCH/RFC] avutil/pixelutils: port ppc/altivec sad functions

[Carl Eugen Hoyos]

Clément Bœsch <u <at> pkh.me> writes:

> +OBJS-$(CONFIG_PIXELUTILS) += ppc/pixelutils_init.o
> +
>  ALTIVEC-OBJS += ppc/float_dsp_altivec.o                                 \
> +ALTIVEC-OBJS-$(CONFIG_PIXELUTILS) += ppc/pixelutils_altivec.o           \

Something is wrong here, I suspect the "\" have 
to be removed.

[...]

> +++ b/libavutil/ppc/pixelutils_altivec.h

> +int ff_pixelutils_sad_8x8_altivec(const uint8_t *src1, ptrdiff_t

ptrdiff_t needs an include of <stdint.h> or similar.

I see the following error running pixelutils-test 
with your patch applied and the above issues 
fixed:

$ make fate-pixelutils
TEST    pixelutils
--- ./tests/ref/fate/pixelutils 2014-08-24 12:18:09.000000000 +0200
+++ tests/data/fate/pixelutils  2014-08-24 14:20:02.000000000 +0200
@@ -1,7 +1,7 @@
 [OK] [UU] SAD [random] 2x2=409 ref=409
 [OK] [UU] SAD [random] 4x4=1370 ref=1370
 [OK] [UU] SAD [random] 8x8=5178 ref=5178
-[OK] [UU] SAD [random] 16x16=20946 ref=20946
+[FAIL] [UU] SAD [random] 16x16=21951 ref=20946
 [OK] [AU] SAD [random] 2x2=320 ref=320
 [OK] [AU] SAD [random] 4x4=1522 ref=1522
 [OK] [AU] SAD [random] 8x8=5821 ref=5821
Test pixelutils failed. Look at tests/data/fate/pixelutils.err for details.
make: *** [fate-pixelutils] Error 1

It passes without the patch.

Sorry about the duplicated work, it takes several 
hours here to compile and gas-preprocessor vs 
configure is completely broken here, the 
preprocessor cannot be detected here.

Carl Eugen