[FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

[Clément Bœsch]

On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote:
> On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote:
> > On 26.08.2014 14:11, Clément Bœsch wrote:
> > >On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote:
> > >[...]
> > >>>I'm fine with the patch, even though Lena has a special meaning in video
> > >>>processing...
> > >>
> > >>yep, i wonder if this is the best solution after sleepng over it.
> > >>the lena image is well known, also people know how girls look,
> > >>people will recognize artiacts easily in it.
> > >>Noone would easily notice if a flower has a different color tone or
> > >>some spots. So it may be better to actually try to keep using lena
> > >>
> > >
> > >Yes. Also, the picture is really under fair use in FFmpeg…
> > >
> > >See also https://en.wikipedia.org/wiki/File:Lenna.png#Fair_use_for_Playboy
> > 
> > Yes, it falls under fair use for FFmpeg. But Debian only accepts
> > files with a DFSG-free license [1], which lena.pnm lacks.
> > 
> 
> > >>In that light ive posted a naive patch that just downloads lena.pnm
> > >>if its missing, a 3rd alternative to that would be to move it to the
> > >>fate suite as andreas initially suggested.
> > >
> > >It's really insane to wget this in a code that worked without access to
> > >the net. The wget is unexpected here. Also, this is probably not going to
> > >help for the package since the goal is to run the tests depending on the
> > >picture.
> > 
> > Downloading lena.pnm won't work for example on Debian's build
> > daemons, which don't allow access to the internet during package
> > build.
> 
> the build daemons run make fate ?
> because the download should only happen when the file is needed
> and its only needed for the tests
> 

make fate works without samples.

Also, if I'm offline and use git clean, I can't run make anymore even if i
still have the samples in a dedicated directory.

Last, it adds a wget dependency.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140826/95900bf6/attachment.asc>