[FFmpeg-devel] [PATCH] lavf/mp3enc: don't abort if audio packets can't be buffered

James Almer jamrial at gmail.com
Wed Aug 27 19:01:51 CEST 2014


On 27/08/14 12:07 PM, Michael Niedermayer wrote:
> On Tue, Aug 26, 2014 at 09:36:38PM -0300, James Almer wrote:
>> Instead skip the picture streams and flush the queued audio packets.
>> Should address ticket #3851.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> This is more a workaround than a "fix" to the issue, with the intent of 
>> not aborting the entire muxing process just because a picture couldn't 
>> be written to the id3v2 tag.
> 
> LGTM
> 

Pushed, thanks.

> maybe the code should be extended by at least a threashold of
> how much can be buffered so theres a limit and it doesnt depend on
> OOM
> 
> [...]
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 



More information about the ffmpeg-devel mailing list