[FFmpeg-devel] [PATCH] Fixed PNG decoding with Paeth filter for RGBA 64-bits.

[Dominique Leroux]

Hi Michael,

Yes, this does fix the issues I saw with RGBA64.

Thanks,

Dominique

-----Original Message-----
From: Michael Niedermayer [mailto:michaelni at gmx.at] 
Sent: Sunday, December 07, 2014 6:55 AM
To: FFmpeg development discussions and patches
Cc: Dominique Leroux
Subject: Re: [FFmpeg-devel] [PATCH] Fixed PNG decoding with Paeth filter for RGBA 64-bits.

Hi

On Sun, Dec 07, 2014 at 05:39:16AM +0100, Michael Niedermayer wrote:
[...]
> >  Changelog                    |  1 +
> >  libavcodec/pngdec.c          | 16 ++++++++++++----
> >  libavcodec/pngdsp.c          |  7 +++++--
> >  libavcodec/pngdsp.h          |  5 +++++
> >  libavcodec/x86/pngdsp_init.c | 17 +++++++++++------
> >  5 files changed, 34 insertions(+), 12 deletions(-)
> 
> this is not correct
> iam a bit tired so i just quickly read your elaborate text but the asm 
> works in steps of bpp not steps of 4 and writes 4 bytes at a time you 
> seem to assume the asm is simpler and more systematic than it actually 
> is, also theres are bugs in the asm i think ive a fix for some of this 
> locally but id like to test it more before pushing

patchset posted, please take a look and review / check / confirm if this fixes all issues you saw

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already.