[FFmpeg-devel] [PATCH] avformat/mov: Disable XMP metadata by default

wm4 nfxjfg at googlemail.com
Tue Dec 9 09:04:31 CET 2014


On Tue,  9 Dec 2014 02:57:01 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:

> This was suggested by cbsrobot, ubitux and koda
> 
> There are files with huge amounts of XMP data, which would otherwise
> be displayed in the terminal output of FFmpeg
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavformat/mov.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 6633a41..9fe124e 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4223,7 +4223,7 @@ static const AVOption mov_options[] = {
>      { "export_all", "Export unrecognized metadata entries", OFFSET(export_all),
>          AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, .flags = FLAGS },
>      { "export_xmp", "Export full XMP metadata", OFFSET(export_xmp),
> -        AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, .flags = FLAGS },
> +        AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, .flags = FLAGS },
>      { NULL },
>  };
>  

If this is a problem, why print metadata at all?

It seems very wrong to export this info optionally just because
ffmpeg.c is too stupid to handle it correctly.

(It might be a problem with other applications too, though. The main
issue is that too many things are exported as metadata, and you can't
distinguish "extra" information from actual "high level" file tags that
can be presented to the user.)


More information about the ffmpeg-devel mailing list