[FFmpeg-devel] [PATCH] avcodec/nvenc: disable on cygwin to avoid _WIN32 definition hack

[Michael Niedermayer]

On Wed, Dec 10, 2014 at 11:08:43PM -0300, James Almer wrote:
> On 10/12/14 10:42 PM, Michael Niedermayer wrote:
> > Suggested-by: jamrial
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/nvenc.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
> > index dc14594..7e5e34e 100644
> > --- a/libavcodec/nvenc.c
> > +++ b/libavcodec/nvenc.c
> > @@ -27,6 +27,7 @@
> >  
> >  /* NVENC API is stdcall in cygwin, as it's still Windows */
> >  #if defined(__CYGWIN__) && !defined(_WIN32)
> > +#error CYGWIN is not supported
> >  #define _WIN32
> >  #define TEMP_WIN32
> >  #endif
> > 
> 
> A configure check for $target_os = cygwin or similar when checking if the 
> header is available is probably a better idea.

patch sent


> Allowing configure to succeed when compilation is known to fail is not a 
> good practice.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141211/06b6f175/attachment.asc>