[FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

[Nicolas George]

Le duodi 22 frimaire, an CCXXIII, Rodger Combs a écrit :
> This also moves general charenc conversion from avcodec to avformat;
> the version in avcodec is left, but renamed; I'm not sure if that's
> the optimal solution.
> 
> The documentation could probably use some improvements, and a few more
> options could be added to ENCA.
> 
> This very simply prefers libguess over ENCA, and ENCA over uchardet, but
> will fall back on a less-preferred guess if something decodes wrong, and will
> drop illegal sequences in iconv if all else fails.
> 
> It'd be possible to have ffmpeg.c present a UI if multiple guesses are
> returned, and other library consumers could do the same.

I will not have time to comment soon enough, but I have reservations about
this patch:

- core feature requiring non-trivial external dependencies;

- renaming an existing option;

- tying proper working of lavc decoders to the use of lavf.

Regards,

-- 
  Nicolas George