[FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

[Lukasz Marek]

On 15.12.2014 14:18, Michael Niedermayer wrote:
>>   cmdutils.c |    8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>> 8d012a5193b0440717f89d920661913ef160e674  0001-cmdutils-dont-call-read_header-before-listing-device.patch
>>  From 332bb7456c498518ea72dfdaa0e8c3e76d383f21 Mon Sep 17 00:00:00 2001
>> From: Lukasz Marek <lukasz.m.luki2 at gmail.com>
>> Date: Mon, 15 Dec 2014 00:31:42 +0100
>> Subject: [PATCH] cmdutils: dont call read_header before listing devices
>>
>> List device callback must be able to return valid list without opening device.
>> This callback should return input values for open function, not vice-versa.
>> Read header funtion is very likey to fail without proper configuration provided.
>
> should be ok

I changed a patch. I wanted to avoid situation where .read_close is 
called without .read_header being called before.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cmdutils-dont-call-read_header-before-listing-device.patch
Type: text/x-patch
Size: 2859 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141217/d91b92e4/attachment.bin>