[FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

[Michael Niedermayer]

On Fri, Dec 19, 2014 at 08:15:26PM +0000, Derek Buitenhuis wrote:
> On 12/19/2014 9:09 PM, Thomas Volkert wrote:
> > +    	av_log(s, AV_LOG_ERROR, "invalid start code %c%c%c%c in RIFF header\n", tag & 0xFF, (tag >> 8) & 0xFF, (tag >> 16) & 0xFF, (tag >> 24) & 0xFF);
> 
> I'm sure printing possibly non-printable chars is a great idea. Nothing
> could go wrong.
> 
> Use 0x%X or something please.

hmm, i suggest av_get_codec_tag_string()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141219/37f64e65/attachment.asc>