[FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

[Michael Niedermayer]

On Tue, Dec 23, 2014 at 09:56:16AM +0530, arwa arif wrote:
> On Mon, Dec 22, 2014 at 10:27 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > On Mon, Dec 22, 2014 at 09:51:25PM +0530, arwa arif wrote:
> > [...]
> >
> > > +static int filter_frame(AVFilterLink *inlink, AVFrame *in)
> > > +{
> > > +    AVFilterContext *ctx = inlink->dst;
> > > +    FSPPContext *fspp = ctx->priv;
> > > +    AVFilterLink *outlink = ctx->outputs[0];
> > > +    AVFrame *out = in;
> > > +
> > > +    int qp_stride = 0;
> > > +    uint8_t *qp_table = NULL;
> > > +    int i, bias;
> > > +    int custom_threshold_m[64];
> > > +
> > > +    bias = (1 << 4) + fspp->strength;
> > > +
> > > +    for (i = 0; i < 64; i++) //FIXME: tune custom_threshold[] and
> > remove this !
> >
> > > +     custom_threshold_m[i] = (uint64_t)(custom_threshold[i] * (bias /
> > 71) + 0.5);
> >
> > it needs to be 71.
> > which is a lazy way to write 71.0 that is a floating point value
> > while 71 is integer and the result of the division differs
> >
> 
> When using 71. , there is a segfault. I tried using float bias instead of
> int bias also, but it still gives segfault.
> How do I resolve it?

the latest patch didnt segfault here


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141223/c958cc67/attachment.asc>