[FFmpeg-devel] SCTE-35 development

[Michael Niedermayer]

On Mon, Dec 29, 2014 at 07:19:14PM +0530, Anshul wrote:
> On 12/29/2014 06:08 PM, Michael Niedermayer wrote:
> > On Mon, Dec 29, 2014 at 01:31:18PM +0530, Anshul wrote:
> >> On December 18, 2014 4:08:56 PM IST, Michael Niedermayer
> >> <michaelni at gmx.at> wrote:
> >>> On Wed, Dec 17, 2014 at 11:53:10PM +0530, Anshul wrote:
> >>>> Hi
> >>>>
> >>>> I was doing development of scte-35  message cue in ffmpeg.
> >>>>
> >>>> I have attached a draft patch.
> >>>>
> >>>> I would like to have some comments of this community.
> >>>> -Anshul
> >>>>  libavcodec/Makefile     |    2 ++
> >>>>  libavcodec/allcodecs.c  |    2 ++
> >>>>  libavcodec/avcodec.h    |    1 +
> >>>>  libavcodec/codec_desc.c |    6 ++++++
> >>>>  libavformat/mpegts.c    |   40
> >>> +++++++++++++++++++++++++++++++++-------
> >>>>  5 files changed, 44 insertions(+), 7 deletions(-)
> >>>> 4b584484a54a78c130c4bbaa48c38551b3ca75fb 
> >>> 0001-trying-muxing-demuxing-of-scte_35-message-cue.patch
> >>>> From 2ff4edfdeae131df72ea19005eb6ad85d5332f7c Mon Sep 17 00:00:00
> >>> 2001
> >>>> From: Anshul Maheshwari <anshul.ffmpeg at gmail.com>
> >>>> Date: Wed, 17 Dec 2014 22:13:10 +0530
> >>>> Subject: [PATCH] trying muxing demuxing of scte_35 message cue
> >>>>
> >>>> ---
> >>>>  libavcodec/Makefile     |  2 ++
> >>>>  libavcodec/allcodecs.c  |  2 ++
> >>>>  libavcodec/avcodec.h    |  1 +
> >>>>  libavcodec/codec_desc.c |  6 ++++++
> >>>>  libavformat/mpegts.c    | 40
> >>> +++++++++++++++++++++++++++++++++-------
> >>>>  5 files changed, 44 insertions(+), 7 deletions(-)
> >>>>
> >>>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> >>>> index b35a796..9d2a49f 100644
> >>>> --- a/libavcodec/Makefile
> >>>> +++ b/libavcodec/Makefile
> >>>> @@ -408,6 +408,7 @@ OBJS-$(CONFIG_SAMI_DECODER)            +=
> >>> samidec.o ass.o
> >>>>  OBJS-$(CONFIG_S302M_DECODER)           += s302m.o
> >>>>  OBJS-$(CONFIG_S302M_ENCODER)           += s302menc.o
> >>>>  OBJS-$(CONFIG_SANM_DECODER)            += sanm.o
> >>>> +OBJS-$(CONFIG_SCTE_35_DECODER)         += scte_35.o
> >>> this patch doesnt contain a scte_35.c
> >>> did you forget git add ?
> >>>
> >>> [...]
> >> I have attached another patch, still its draft.
> >> I do want some opinion about the approach of this development.
> >>
> >> to use this patch, one can pass below command
> >> ./ffmpeg -loglevel debug -i ~/test_videos/mpegwithscte35.ts -dcodec
> >> cue_xml -map 0:0 -f rawvideo some.raw
> >>
> >> There still some issue with this patch, like I have disabled estimate
> >> timing of all stream since data stream does not have similar timing, i
> >> will add condition there.
> >>
> >> FFmpeg hangs after running command, it might be because of EOF not
> >> handled properly, looking at the issue.
> >>
> >>
> >> My vision for this patch is that we can add custom advertisement
> >> if stream have scte-cue.
> >>
> >> This patch might also help end-user to remove advertisements automatically.
> >>
> >> for broadcaster it will help to show advertisement in local language.
> >> or for local product.
> >> just now I am very far away from my goal but will not always be.
> >>
> >>
> >> This patch have all files which I have developed.
> > ar: libavcodec/scte_35.o: No such file or directory
> >
> > [...]
> >
> >
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> I am sorry, I attached the wrong patch file.
> -Anshul

>  ffmpeg.c                |   40 ++++++
>  ffmpeg_opt.c            |    9 -
>  libavcodec/Makefile     |    2 
>  libavcodec/allcodecs.c  |    2 
>  libavcodec/avcodec.h    |   17 ++
>  libavcodec/codec_desc.c |   12 +
>  libavcodec/cue_xml.c    |  196 ++++++++++++++++++++++++++++++++
>  libavcodec/scte_35.c    |  294 ++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/scte_35.h    |   31 +++++
>  libavcodec/utils.c      |   33 ++++-
>  libavformat/avformat.h  |   16 ++
>  libavformat/mpegts.c    |   44 ++++++-
>  libavformat/utils.c     |    3 
>  libavutil/avstring.c    |   26 ++++
>  libavutil/avstring.h    |   15 ++
>  15 files changed, 724 insertions(+), 16 deletions(-)
> 5e5649190d21989599df2f78194b28ed29ebdae7  0001-trying-handle-scte_35-messagecue.patch
> From 6e04f65c33c4d4f873bbadabcc9d1d8464d49314 Mon Sep 17 00:00:00 2001
> From: Anshul Maheshwari <anshul.ffmpeg at gmail.com>
> Date: Mon, 29 Dec 2014 12:42:41 +0530
> Subject: [PATCH] trying handle scte_35 messagecue

Applying: trying handle scte_35 messagecue
fatal: sha1 information is lacking or useless (libavcodec/Makefile).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 trying handle scte_35 messagecue
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141229/a493768c/attachment.asc>