[FFmpeg-devel] Patch: icl linker errors in cmdutils

[Matt Oliver]

On 8 February 2014 19:45, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Matt Oliver <protogonoi <at> gmail.com> writes:
>
> > If this patch had instead been submitted as "Optimize by
> > removing unnecessary if(0)/if(1) in cmdutils" would it
> > have been more likely to have been accepted.
>
> Optimization patches need benchmarks.
>
> > Relying on a compiler to remove unneeded code
> > is generally not a good idea
>
> FFmpeg relies on dead-code-elimination on many, many
> places in the source, even compilers that fail FFmpeg
> compilation succeed with dead-code elimination.
>
> Are you using FFmpeg's configure script?
> If yes, how does your configure line looks like?
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Fair enough, im running a custom build chain that runs portions of
configure but interprits it and runs it through a native Visual Studio
build environment. Hence having /Qipo issues as that is automatically
enabled under standard Visual Studio release builds but is not as standard
enabled when running from a MSYS/Cygwin command line environment. As such
/Qipo would be an additional option that would have to be passed to
configure (cant remember if it should be passed with the /Q bit or not). If
this is considered non-standard behaviour that wont be supported then fine
ill just keep the fix in my local repository. I just figured that should
someone else run into this at some stage later having it available would be
useful.