[FFmpeg-devel] [PATCH] lavd: add uncoded_frame test program.

[Clément Bœsch]

On Sat, Feb 08, 2014 at 05:09:31PM +0100, Nicolas George wrote:
> Le decadi 20 pluviôse, an CCXXII, Michael Niedermayer a écrit :
> > Makefile:111: target `tools/uncoded_frame' doesn't match the target pattern
> 
> Fixed using:
> 
> +PROGS += tools/uncoded_frame$(PROGSSUF)$(EXESUF)
> 
> > with the exampl:
> > 
> > tools/uncoded_frame movie=file.nut:s=v+a uncodedframecrc:pipe:0
> > [sonic @ ] The decoder 'sonic' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it.
> > [nut @ ] Failed to open codec in av_find_stream_info
> > [sonic @ ] The decoder 'sonic' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it.
> > [Parsed_movie_0 @ ] Stream specifier "v" did not match any stream
> > Error initializing filter 'movie' with args 'file.nut:s=v+a'
> > Unable to parse graph: Invalid argument
> > Segmentation fault (core dumped)
> 
> Hopefully fixed.
> 
> > it appears the segfault happens with any file that has just audio
> > though
> 
> The segfault would happen whenever the input graph could not be initialized,
> due do clean-up on an array that was not yet allocated. That is fixed.
> 
> It fails with any file that has just audio because you kept ":s=v+a", and
> there is no video stream.
> 
> New patch attached, thanks for the testing.
> 
> Regards,
> 
> -- 
>   Nicolas George

> From 35224b6e17dd918f532d2f0c5351d584b78fb781 Mon Sep 17 00:00:00 2001
> From: Nicolas George <george at nsup.org>
> Date: Mon, 3 Feb 2014 09:12:27 +0100
> Subject: [PATCH] tools: add uncoded_frame test program.
> 
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  Makefile              |   2 +
>  tools/uncoded_frame.c | 277 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 279 insertions(+)
>  create mode 100644 tools/uncoded_frame.c
> 
> diff --git a/Makefile b/Makefile
> index 7317f25..2d32da5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,6 +34,8 @@ HOSTPROGS  := $(TESTTOOLS:%=tests/%) doc/print_options
>  TOOLS       = qt-faststart trasher
>  TOOLS-$(CONFIG_ZLIB) += cws2fws
>  
> +PROGS += tools/uncoded_frame$(PROGSSUF)$(EXESUF)
> +

Why is this part of the PROGS? PROGS are for the main fftools. Shouldn't
it be TESTPROGS?

Also, why not make it part of the examples instead?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140208/d897d07b/attachment.asc>