[FFmpeg-devel] [PATCH] set FONTCONFIG_PATH relative to ffmpeg binary, if it is a static build

[Nicolas George]

Le nonidi 29 pluviôse, an CCXXII, Helmut Tessarek a écrit :
> I agree that my condition is not optimal and I like your idea of a new
> configure option. I should have thought of it, but my patch was rather a quick
> hack to see what people think.
> 
> --enable-portable[=path]
> --enable-rel-fc-path[=path]
> --enable-relative-fontconfig-path[=path]
> 
> I like your --enable-portable, since it is shorter than the others, although
> it is quite generic.

Try not to over-think it. A simple option can be extended later if the need
arises.

> I'll work on a new configure option and make the changes Nicolas suggested.
> 
> My only concern is the following: Nicolas mentioned that the user-provided
> value should take precedence. I think there are use cases for both.
> Let's assume a person has a static build or a bundled ffmpeg version that
> includes the necessary fontconfig files (relative to the binary). In that case
> I want ffmpeg to use the bundled fontconfig files and not the ones that might
> be installed on the system.
> So if I set the --enable-portable[=path] config option, this path should take
> precedence.

I really do not think so. When fontconfig is installed system-wide, it
hard-codes the path to its config files, there is no need for the
environment variable.

Therefore, if the environment variable is set, you have to assume it was set
on purpose.

Another point: if the environment variable is set for some reason and it
should not, the user can remove it. If ffmpeg overrides it and guesses the
value wrong, there is nothing to be done.

Basic rule of tools for advanced users: in the end, the users always know
best, especially about their system.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140217/2bc5bdde/attachment.asc>