[FFmpeg-devel] (Reviewing old code) fifo_size=0 in rtpproto.c

Andrey Utkin andrey.krieger.utkin at gmail.com
Wed Feb 19 18:03:39 CET 2014


The change introduced 3 years ago seem to be a reason of problems with
RTSP/UDP stream integrity: see
http://www.zoneminder.com/forums/viewtopic.php?f=30&t=21911

The commit which is proposed to revert in discussion referenced above:

commit 158eb8599a2811ad8eed9939878982f172b79a89
Author: Michael Niedermayer <michaelni at gmx.at>
Date:   Mon Jul 25 15:50:56 2011 +0200

    rtp: disable udp fifos, the rtp code cannot work with the fifos in
its current form as rtp bypasses the public API.

    Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

diff --git a/libavformat/rtpproto.c b/libavformat/rtpproto.c
index 6e76825..d2ce53c 100644
--- a/libavformat/rtpproto.c
+++ b/libavformat/rtpproto.c
@@ -115,6 +115,7 @@ static void build_udp_url(char *buf, int buf_size,
         url_add_option(buf, buf_size, "pkt_size=%d", max_packet_size);
     if (connect)
         url_add_option(buf, buf_size, "connect=1");
+    url_add_option(buf, buf_size, "fifo_size=0");
 }

 /**


Is there still a reason for this line being here? Can we remove it?
BTW is there any agreed way to passthrough transport level options for
RTSP and RTP (de)muxer?

-- 
Andrey Utkin


More information about the ffmpeg-devel mailing list