[FFmpeg-devel] [PATCH] lavf/mux: check av_dup_packet() return value.

[Michael Niedermayer]

On Wed, Feb 19, 2014 at 05:44:55PM +0100, Nicolas George wrote:
> Le quintidi 15 nivôse, an CCXXII, Michael Niedermayer a écrit :
> > On Sat, Jan 04, 2014 at 05:39:10PM +0100, Nicolas George wrote:
> > > 
> > > Signed-off-by: Nicolas George <george at nsup.org>
> > > ---
> > >  libavformat/mux.c |    7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > 
> > > Simulating the failure (this_pktl->pkt.size = 2000000000) leaks with
> > > ffmpeg_g, but that is to be expected since it calls exit_program(1)
> > > immediately.
> > 
> > LGTM
> 
> This commit somehow disappeared from my tree. Here is a rebased version.
> 
> Regards,
> 
> -- 
>   Nicolas George

>  mux.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> a2015a28f9fd087c1982ab5286ae7e6e9bf0d10c  0001-lavf-mux-check-av_dup_packet-return-value.patch
> From c7c919f1a74df925e169204874eed5d0fdfe37b8 Mon Sep 17 00:00:00 2001
> From: Nicolas George <george at nsup.org>
> Date: Wed, 19 Feb 2014 17:43:46 +0100
> Subject: [PATCH] lavf/mux: check av_dup_packet() return value.
> 
> Signed-off-by: Nicolas George <george at nsup.org>

applied so its not lost again

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140220/cd863d2f/attachment.asc>