[FFmpeg-devel] [PATCH 4/8] lavu/opt: extend AVOptionRange by second value

[Lukasz Marek]

On 24.02.2014 12:52, wm4 wrote:
> On Sat, 22 Feb 2014 23:33:38 +0100
> Lukasz Marek <lukasz.m.luki at gmail.com> wrote:
>
>
>>   typedef struct AVOptionRange {
>>       const char *str;
>> -    double value_min, value_max;             ///< For string ranges this represents the min/max length, for dimensions this represents the min/max pixel count
>> -    double component_min, component_max;     ///< For string this represents the unicode range for chars, 0-127 limits to ASCII
>> -    int is_range;                            ///< if set to 1 the struct encodes a range, if set to 0 a single value
>> +    /**
>> +     * AV_OPT_TYPE_IMAGE_SIZE options use both elements to represent width and height ranges.
>> +     * Other options uses only first elements.
>> +     * For string ranges first elements represent the min/max length.
>> +     */
>> +    double value_min[2], value_max[2];
>> +    /**
>> +     * For string this represents the unicode range for chars, 0-127 limits to ASCII
>> +     */
>> +    double component_min, component_max;
>> +    /**
>> +     * If set to 1 the struct encodes a range, if set to 0 a single value
>> +     */
>> +    int is_range;
>>   } AVOptionRange;
>
> I don't think you can do that without a major API bump. At least
> nothing suggests that this struct is not public.

Yes, thanks I got suggested by Micheal's suggestion and didn't think 
about it. I added new fields at the end of the struct.

I will send updated patches 5-8 later. But I would be glad to not 
postpone merging 1-4 more than needed.

-- 
Best Regards,
Lukasz Marek

I may be drunk, Miss, but in the morning I will be sober and you will 
still be ugly. - Winston Churchill
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lavu-opt-extend-AVOptionRange-by-extra-values.patch
Type: text/x-patch
Size: 1332 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140225/7af7adaa/attachment.bin>