[FFmpeg-devel] [PATCH] x86/imdct36: don't build imdct36_float_sse on x86_64 targets

[James Almer]

On 27/02/14 6:42 AM, Michael Niedermayer wrote:
> On Thu, Feb 27, 2014 at 02:07:58AM -0300, James Almer wrote:
>> There's an SSE2 version as well, and x86_64 guarantees that
>> instruction set is present.
> 
> is the size gain worth the extra ifdefery ?

About 3kb after stripping.
There were other functions where the size gain was negligible or virtually 
non existent so i didn't bother with them.

> also iam not sure how likely it is but someone might want to test
> the SSE code and as is it could be done without recompiling while
> after this patch one would need to build for x86_32 first
> 
> either way iam not against applying it if you/others think its better
> with that extra checks

The checks are made by the pre-processor, so it's not like we're getting 
extra runtime code anyway. It's the other way around, even.