[FFmpeg-devel] [FFmpeg-cvslog] Fix http authentication.

[Clément Bœsch]

On Fri, Feb 28, 2014 at 02:49:39AM +0100, Michael Niedermayer wrote:
> On Thu, Feb 27, 2014 at 08:30:00PM +0100, Clément Bœsch wrote:
> > On Thu, Feb 27, 2014 at 08:25:52PM +0100, Carl Eugen Hoyos wrote:
> > > ffmpeg | branch: master | Carl Eugen Hoyos <cehoyos at ag.or.at> | Wed Feb 26 09:51:06 2014 +0100| [3ba056017f978ba69ea933c593f0e616b3632261] | committer: Carl Eugen Hoyos
> > > 
> > > Fix http authentication.
> > > 
> > > Add parenthesis around "MD5" in the request string as required by
> > > RFC 2069.
> > > 
> > 
> > Sorry to raise that now but RFC 2069 is obsoleted by RFC 2617:
> > http://tools.ietf.org/html/rfc2617
> > 
> > And the BNF in that RFC says:
> >       algorithm         = "algorithm" "=" ( "MD5" | "MD5-sess" |
> >                            token )
> > 
> > The quotes should not be present AFAICT.
> 
> seems so, thats my mistake, feel free to revert
> (or leave it if that turns out to work with more servers)
> 

Well, it seems the other implementations send & accept with quotes
generally. But this is not matching the RFC, even the first version
mentioned:

  algorithm           = "algorithm" "=" ( "MD5" | token )

So the commit message is actually wrong.

I'd "fix" it by adding a comment in the code saying that we are violating
the RFC because all others seem to do that.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140228/264e1f99/attachment.asc>