[FFmpeg-devel] [PATCH 06/19] avformat: add AVFMT_RAW_ID3 for demuxers requiring unstripped ID3

[Michael Niedermayer]

On Fri, Jan 03, 2014 at 04:21:30PM +0200, Anssi Hannula wrote:
> This is needed by hls_id3_audio since the ID3 tag contains private
> timestamp data needed by read_header() and read_probe().
> 
> Signed-off-by: Anssi Hannula <anssi.hannula at iki.fi>
> ---
> 
> This is needed with the new separate subdemuxer approach, otherwise
> the first ID3 tag would be stripped by generic code. Better suggestions
> welcome.
> 
>  libavformat/avformat.h |  3 +++
>  libavformat/utils.c    | 12 ++++++++----
>  2 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 6d719d7..3d46bf1 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -377,6 +377,9 @@ typedef struct AVProbeData {
>                                          AVFormatContext.avoid_negative_ts
>                                          */
>  
> +#define AVFMT_RAW_ID3      0x80000 /**< Format requires raw ID3 tags to not be
> +                                        parsed/stripped before read_header */
> +
>  #define AVFMT_SEEK_TO_PTS   0x4000000 /**< Seeking is based on PTS */

please move AVFMT_RAW_ID3 after AVFMT_SEEK_TO_PTS and give it a value
larger than AVFMT_SEEK_TO_PTS.
This reduces the risk of compatibility issues with the fork

otherwise patch LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140103/70ebefc1/attachment.asc>