[FFmpeg-devel] [PATCH v2] tools/qt-faststart: add -movflags +faststart note

[Clément Bœsch]

On Mon, Jan 06, 2014 at 12:33:23PM -0900, Lou Logan wrote:
> On Mon, 6 Jan 2014 22:15:50 +0100, Clément Bœsch wrote:
> 
> > On Mon, Jan 06, 2014 at 11:49:21AM -0900, Lou Logan wrote:
> > > ---
> > >  tools/qt-faststart.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c
> > > index cb36c43..61bf93b 100644
> > > --- a/tools/qt-faststart.c
> > > +++ b/tools/qt-faststart.c
> > > @@ -102,7 +102,8 @@ int main(int argc, char *argv[])
> > >      int bytes_to_copy;
> > >  
> > >      if (argc != 3) {
> > > -        printf("Usage: qt-faststart <infile.mov> <outfile.mov>\n");
> > > +        printf("Usage: qt-faststart <infile.mov> <outfile.mov>\n"
> > > +               "This tool has been deprecated by -movflags +faststart in ffmpeg\n");
> > 
> > I wouldn't say deprecated, but maybe just mention the feature.
> 
> Ok. I never did like that word anyway.
> 

Especially when related to a tool I suppose :)

> > maybe, "Note: ffmpeg can now do this operation using -movflags
> > +faststart". As you quoted, the tool has its benefits (no need to worry
> > about a partial header reconstruction, and probably faster).
> 
> I changed it to:
> "Note: Alternatively you can use -movflags +faststart in ffmpeg"
> 

Fine with me, but I'm not the qt-faststart maintainer.

(nit: no caps on the first 'A')

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140107/a2cf387b/attachment.asc>