[FFmpeg-devel] [PATCH] oggparseskeleton: return 0 on EOS packet

[James Almer]

On 08/01/14 5:26 PM, Michael Niedermayer wrote:
> On Wed, Jan 08, 2014 at 04:35:18PM -0300, James Almer wrote:
>> On 08/01/14 4:26 PM, Michael Niedermayer wrote:
>>> On Mon, Jan 06, 2014 at 10:05:31PM -0300, James Almer wrote:
>>>> I uploaded both files to the ftp, theora_skel.ogv and vp8_skel.ogv if you want to check.
>>>
>>> files not found
>>
>> I uploaded them again, but this time it gave me a timeout error then a "can't rewrite" one.
>> MD5 for theora_skel.ogv is 8086ede95a8ba69c633d084827634776 and 
>> 2b581456d99b2a9ac42a25c68d9f1401 for vp8_skel.ogv
>>
>> If they still don't show up or they are broken I'll try uploading somewhere else.
> 
> with this patch the demuxer outputs a empty packet from the data
> stream
> 
>  -i vp8_skel.ogv -c copy -map 0 -f framecrc -
> 
> 0,          0,          0,        1,     5014, 0x4798fa33
> 1,          0,          0,        0,        0, 0x00000000
> 0,          1,          1,        1,      822, 0x596486c5, F=0x0
> 0,          2,          2,        1,      840, 0xf06490ba, F=0x0
> ...
> 
> is this intended ?

No. Seems that returning 0 on EOS makes the demuxer think it's a data packet rather than 
the last header.

Patch dropped then.