[FFmpeg-devel] [PATCH 1/5] lavf: add write_uncoded_frame() API.

[Michael Niedermayer]

On Wed, Jan 15, 2014 at 11:30:00PM +0100, Nicolas George wrote:
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavformat/avformat.h | 46 +++++++++++++++++++++++++++++
>  libavformat/internal.h | 14 +++++++++
>  libavformat/mux.c      | 79 +++++++++++++++++++++++++++++++++++++++++++++++---
>  3 files changed, 135 insertions(+), 4 deletions(-)
> 
> 
> Changes since previous series:
> 
> * av_(interleaved_)write_uncoded_frame() takes ownership of the frame.
> 
> * AVOutputFormat.write_uncoded_frame() takes a pointer to the frame pointer,
>   so it can prevent the library from freeing it.
> 
> * Simplify pts computation.
> 
> TODO (separate patches):
> 
> * Emulate write_packet() using write_uncoded_frame() to allow muxers to
>   implmement only one.
> 
> * FATE tests.
> 
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 6d719d7..3fe6c3e 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -453,6 +453,14 @@ typedef struct AVOutputFormat {
>  
>      void (*get_output_timestamp)(struct AVFormatContext *s, int stream,
>                                   int64_t *dts, int64_t *wall);
> +
> +    /**
> +     * Write an uncoded AVFrame.
> +     *
> +     * See av_write_uncoded_frame() for details.
> +     */
> +    int (*write_uncoded_frame)(struct AVFormatContext *, int stream_index,
> +                               AVFrame **frame, unsigned flags);

Maybe add 1 line that explains the **frame

LGTM otherwise

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140116/f03151bf/attachment.asc>