[FFmpeg-devel] [PATCH] fateserver: add FFmpeg website-style banner and navbar

[Clément Bœsch]

On Sat, Jan 18, 2014 at 11:08:01AM -0800, Timothy Gu wrote:
> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> ---
>  history.cgi | 29 +++++++++++++++++++++++++++++
>  index.cgi   | 29 +++++++++++++++++++++++++++++
>  report.cgi  | 29 +++++++++++++++++++++++++++++
>  3 files changed, 87 insertions(+)
> 
> diff --git a/history.cgi b/history.cgi
> index 2c897cb..a6e608b 100755
> --- a/history.cgi
> +++ b/history.cgi
> @@ -37,11 +37,39 @@ tag 'meta', 'http-equiv' => "Content-Type",
>              'content'    => "text/html; charset=utf-8";
>  tag 'link', rel  => 'stylesheet',
>              type => 'text/css',
> +            href => '//ffmpeg.org/default.css';
> +tag 'link', rel  => 'stylesheet',
> +            type => 'text/css',
>              href => '/fate.css';
>  print "<title>FATE: $slot</title>\n";
>  end 'head';
>  
>  start 'body';
> +start 'div', id => 'container';
> +
> +# Copied from ffmpeg-web
> +print <<EOF;
> +<div id="banner">
> +<a href="//ffmpeg.org/index.html">
> +<img src="//ffmpeg.org/ffmpeg-logo.png" alt="FFmpeg">
> +</a>
> +</div>
> +<div id="navbar">
> +<a href="//ffmpeg.org/index.html">News</a> |
> +<a href="//ffmpeg.org/about.html">About</a> |
> +<a href="//ffmpeg.org/download.html">Download</a> |
> +<a href="//ffmpeg.org/documentation.html">Documentation</a> |
> +<a href="//ffmpeg.org/bugreports.html">Bug Reports</a> |
> +<a href="//ffmpeg.org/contact.html">Contact</a> |
> +<a href="//ffmpeg.org/donations.html">Donations</a> |
> +<a href="//ffmpeg.org/consulting.html">Consulting</a> |
> +<a href="//ffmpeg.org/projects.html">Projects</a> |
> +<a href="//ffmpeg.org/legal.html">Legal</a> |
> +<a href="//ffmpeg.org/security.html">Security</a> |
> +<a href="http://fate.ffmpeg.org">FATE</a>

what's with this "//ffmpeg.org" href? Is there some postprocessing madness
fixing the link later, or that's just plain broken?

Also, can't you avoid duplicating this code 3x?

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140118/6382473c/attachment.asc>