[FFmpeg-devel] [PATCHv5 2/3] vorbis: append data from tags together

[Ben Boeckel]

On Fri, 17 Jan, 2014 at 21:46:09 GMT, Michael Niedermayer wrote:
>> +                int extra_flags =3D 0;
>> +                if (m && av_dict_get(*m, tt, NULL, 0)) {
>> +                    extra_flags =3D AV_DICT_APPEND;
>> +                    --vt;
>> +                }
>
> the check for m != null shouldnt be needed,

'm' is dereferenced on the same line.

> also extra_flags shouldnt be needed, AV_DICT_APPEND should have no
> effect if theres no previous matching entry

Done.

> also av_dict_set(m, tt, ";", AV_DICT_APPEND);
> should be simpler than all the changes to ct/vt

Oops, yeah. Don't know why I didn't see that. This patch is now *much*
simpler.

--Ben