[FFmpeg-devel] [PATCH] Properly handle cookies that specify sub-domain where the URL.

[Eli Kara]

Hmm,

I'll remove the tabs (I'm not sure how they got in there) but what do you propose?
The usage of the leading_dot variable is to clarify that the cookie specifies a sub-domain.
Yes, you could write:

Int leading_dot = (param[7] == '.');

But technically, the result of the expression is a boolean, not an int. I'm open to suggestions since I'm not regularly following
ffmpeg and I'm not familiar with your coding style (I was sure this was acceptable).

Eli

-----Original Message-----
From: ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Carl Eugen Hoyos
Sent: Wednesday, January 22, 2014 3:23 PM
To: ffmpeg-devel at ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] Properly handle cookies that specify sub-domain where the URL.

Eli Kara <eli <at> algotec.co.il> writes:

> +                // the domain in the URL should be at least
> the size of our cookie domain. correctly support sub-domains AND the 
> master domain
> +                // by not comparing the dot at all (ex: 
> domain=bar.com and cdomain=.bar.com)

Please try to fix the length of the comment lines.

> +				int leading_dot = (param[7] == '.') ? 1 : 0;

tabs cannot be committed to the FFmpeg repository, please remove them and consider using tools/patcheck.

I suspect you can remove the additional variable (or the "?").

Carl Eugen

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel