[FFmpeg-devel] BUG in use of extradata and extradata_size with dvb subtitles and teletext

[Marton Balint]

On Sat, 25 Jan 2014, Andriy Lysnevych wrote:

>> In your patch there are some completely unrelated changes to the teletext
>> code as well, split the patch first to a teletext part and a dvbsub part at
>> least.
>>
>> Regards,
>> Marton
>>
>
> Fixed, see attached.
>
> Regards,
> Andriy Lysnevych
>

[...]

> This patch changes AVStream.extradata format of DVB subtitle streams
> in MPEG-TS muxer and demuxer.

I don't think that is acceptable breakage, but others may know this 
better. To make sure things don't break too badly a better solution maybe 
is to put the subtitling_type byte AFTER the composition and ancillary 
page id, even if that is different from the order in the subtitling 
descriptor.

Also make sure the dvbsub decoder codec still works after your patch, 
since it is using extradata...

Regards,
Marton