[FFmpeg-devel] [PATCH 2/5] ffmpeg: use the write_uncoded_frame() API.

[Nicolas George]

Le septidi 7 pluviôse, an CCXXII, Michael Niedermayer a écrit :
> The user provides a AVFrame to an encoder and the (raw) encoder
> would do the magic encapsulation of the AVFrame into a AVPacket
> 
> If a user wants to send a AVFrame directly to a muxer then this
> would call the uncoded_frame API which takes a AVFrame and this would
> then do the magic encapsulation if needed (thats identical your API)
> (strictly speaking the uncoded frame API could call the rawvideo
>  encoder or share code with it to do it)

Oh, now I understand what you meant: an additional helper API, and not a
replacement for the proposal.

I do not like it, because the resulting packet is not a real packet and
therefore needs to be handled very carefully. Handling that in the API would
require quite a few checks, and that still would not prevent the application
from doing things that are legitimate with a real packet but completely
broken with that kind of pseudo packet. But if the use is completely
optional this is not a blocking issue.

And, unless I am mistaken, deciding on this issue is not blocking for this
patch series (except maybe #2).

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140127/24d46623/attachment.asc>