[FFmpeg-devel] [PATCH 1/8] avcodec/old_codec_ids: workaround doxygen inclusion bug

Timothy Gu timothygu99 at gmail.com
Fri Jul 4 20:06:40 CEST 2014


Currently, http://ffmpeg.org/doxygen/trunk/group__preproc__misc.html is
broken, because of inclusion bug in Doxygen's preprocessing mode. The
now-unincluded header file is included anyway in avcodec.h, the only
place where it is used, so there should be no problem removing it.

One concern is API-compatibility, because old_codec_ids.h is a public
header. However, IMO this is not a problem because currently users
cannot include only this header and not `avcodec.h` anyway, because of
missing AV_CODEC_ID_NONE symbol.

Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
---
 libavcodec/old_codec_ids.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavcodec/old_codec_ids.h b/libavcodec/old_codec_ids.h
index b956264..c7aa0e0 100644
--- a/libavcodec/old_codec_ids.h
+++ b/libavcodec/old_codec_ids.h
@@ -19,8 +19,6 @@
 #ifndef AVCODEC_OLD_CODEC_IDS_H
 #define AVCODEC_OLD_CODEC_IDS_H
 
-#include "libavutil/common.h"
-
 /*
  * This header exists to prevent new codec IDs from being accidentally added to
  * the deprecated list.
-- 
1.9.1



More information about the ffmpeg-devel mailing list