[FFmpeg-devel] [PATCH][BULK][again] new multimedia filter avf_showcqt.c

[Michael Niedermayer]

On Sun, Jun 01, 2014 at 07:29:14AM -0700, Muhammad Faiz wrote:
> On Fri, May 30, 2014 at 6:09 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> >
> > you can try libavutil/qsort.h which would avoid some overhead of
> > qsort()
> > also the abs() does not need to be done in the compare function,
> > it could be done outside
> >
> > or if its still slow, this can be done using a radix sort
> > (this would require the floats to be read as integers)
> >
> >
> > [...]
> > > +        for (x = 0; x < VIDEO_WIDTH; x += VIDEO_WIDTH/10)
> > > +        {
> > > +            int u;
> >
> > > +            const char *str = "EF G A BC D ";
> >
> > static const
> >
> > and SIMD optimizations of the most speed critical part would make
> > sense if you know asm
> >
> > Also you probably want to add yourself to the MAINTAINERs file for
> > showcqt
> >
> 
> SIMD optimizations, not yet.
>  Thank's.

btw, do you intentionally ignore every 2nd comment ?

its ok if you dont have time / dont want to implement some changes
but please reply to them, dont just ignore them

about the hardcoded 1920/1080 resolution, i assume thats a result
of the fixed font ?
In principle freetype could be used instead if you want to avoid
the fixed font

also if you dont want to maintain the code ?
do you know someone else who might want to maintain the code

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140601/74910296/attachment.asc>