[FFmpeg-devel] [PATCH] Add flag to drop non-forced subtitle

[Michael Niedermayer]

On Mon, May 26, 2014 at 11:47:56AM +0200, Oliver Fromme wrote:
> Clément B½sch wrote:
>  > On Thu, May 22, 2014 at 07:39:11PM +0200, Oliver Fromme wrote:
>  > > Hello,
>  > > 
>  > > As I mentioned earlier this week, I'm trying to improve support
>  > > for forced and partially forced subtitles.  The patch below is
>  > > the next step.
>  > > 
>  > > The patch changes four files.  I'll explain in detail what the
>  > > changes are good for:
>  > > 
>  > > libavcodec/avcodec.h -- Introduce a new codec flag for subtitle
>  > > encoders, it's called CODEC_FLAG_FORCED_SUBS.  When set, this
>  > > flag indicates that the encoder should write only such subtitle
>  > > frames that are marked as forced.  Frames that are *not* forced
>  > > will be ignored by the encoder.
>  > > 
>  > 
>  > > By the way, is there a rule for allocating bit masks for new
>  > > flags?  I just took the first unused one, that is 0x0080.
>  > > 
>  > 
>  > Yes, we generally introduce a gap between the last added one and the new
>  > one, unless the last one added was FFmpeg specific in order to keep
>  > compatibility with the fork Libav.
> 
> Oh, ok ...  So what value should be used for my patch?
> I'm a bit confused; the existing constants don't even seem
> to be sorted numerically.  Or should I even use flags2
> instead of flags?

not sure whats confusing
libav adds flags normally on a lowest availailble first basis, so by
picking something from the other end,  conflicts become less likely

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140602/57296bd6/attachment.asc>